Skip to content

fix(clerk-js): Fix badge misalignment on tables list when title is empty#2908

Merged
octoper merged 3 commits intomainfrom
vaggelis/sdk-1429-the-you-badge-in-organization-members-seems-off-when-user
Mar 1, 2024
Merged

fix(clerk-js): Fix badge misalignment on tables list when title is empty#2908
octoper merged 3 commits intomainfrom
vaggelis/sdk-1429-the-you-badge-in-organization-members-seems-off-when-user

Conversation

@octoper
Copy link
Copy Markdown
Member

@octoper octoper commented Mar 1, 2024

Description

This PR adds a check to only render the preview title for UserPreview component only when it's not empty, that happens to avoid any weird gaps when a badge exists and the preview tile is empty.

Before

CleanShot 2024-03-01 at 14 40 33@2x

After

CleanShot 2024-03-01 at 14 32 52@2x

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@octoper octoper requested review from anagstef and desiprisg March 1, 2024 12:43
@octoper octoper self-assigned this Mar 1, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 1, 2024

🦋 Changeset detected

Latest commit: a1c502f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
Copy link
Copy Markdown
Member Author

octoper commented Mar 1, 2024

!preview

@clerk-cookie
Copy link
Copy Markdown
Collaborator

clerk-cookie commented Mar 1, 2024

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Mar 01, 2024 12:50 PM

Copy link
Copy Markdown
Contributor

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Let's add a changeset! 🚀

@octoper octoper force-pushed the vaggelis/sdk-1429-the-you-badge-in-organization-members-seems-off-when-user branch from 8c1bb8f to a1c502f Compare March 1, 2024 13:21
@octoper octoper enabled auto-merge March 1, 2024 13:21
@octoper octoper added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 98b194b Mar 1, 2024
@octoper octoper deleted the vaggelis/sdk-1429-the-you-badge-in-organization-members-seems-off-when-user branch March 1, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants